feat(ui5-dynamic-page): add responsive paddings #7846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kineticjs
force-pushed
the
dp-responsive-margins
branch
from
82e51fd to
8dafdfb
Compare
|
As we are about to replace all ResizeHandler media range based attributes with container queries: #7666, could we also use them here? |
|
Ignore my last comment, we stick to resize handlers for now. |
|
|
||
| /* Responsive paddings */ | ||
|
|
||
| :host([media-range="S"]) .ui5-dynamic-page-root { |
There was a problem hiding this comment.
I guess we should set paddings to all components of the dynamic page individually - title, header, content. This way the background and the box-shadow of the title will be visible through the whole width of the page. Also the footer seems to not need paddings as well.
Notice that I've changed the body background here:
kineticjs
force-pushed
the
dp-responsive-margins
branch
from
dcec831 to
6453f54
Compare
dobrinyonkov
approved these changes
Nov 27, 2023
kineticjs
force-pushed
the
dp-responsive-margins
branch
from
6453f54 to
c143204
Compare
|
merge issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add left/right responsive paddings